Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use stderr for cli messages #4022

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

dandanlen
Copy link
Collaborator

println!();
println!("{}", keys);
println!("{}", DISCLAIMER);
eprintln!();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use \n instead of the empty printlns?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 It's nicer to read? Keeps everything in line etc...

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #4022 (6c0c95a) into main (c69bccf) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4022   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        366     366           
  Lines      57967   57967           
  Branches   57967   57967           
=====================================
+ Hits       42031   42034    +3     
+ Misses     13836   13833    -3     
  Partials    2100    2100           

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen merged commit ea927f1 into main Sep 19, 2023
44 checks passed
@dandanlen dandanlen deleted the fix/use-stderr-for-cli-messages branch September 19, 2023 14:26
ahasna pushed a commit that referenced this pull request Sep 19, 2023
dandanlen added a commit that referenced this pull request Sep 21, 2023
dandanlen added a commit that referenced this pull request Sep 28, 2023
dandanlen added a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants